Repository navigation
refactor(chat): drop Superset MCP tools from v1 chat runtime - #6031
Conversation
v2 chat deliberately dropped Superset MCP tools; v1 chat was the last internal consumer of the deprecated /api/agent/mcp endpoint. Also points the local dev setup script at the v2 MCP URL — every checked-in agent config already uses v2. Claude-Session: https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
|
Ready to review this PR? Stage has broken it down into 2 individual chapters for you:
Chapters generated by Stage for commit 0f7e61f on Jul 28, 2026 10:16pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe local MCP setup URL now targets ChangesMCP integration alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Part of the MCP v2 rework (Phase 0d) — this starts the v1 MCP sunset clock: v1 chat was the last internal consumer of the deprecated
/api/agent/mcpendpoint.getSupersetMcpTools(Mastra MCP client pointed at v1) and its only call site in the chat runtime. This matches v2 chat, which deliberately dropped Superset MCP tools (plans/v1-to-v2-fast-migration.md)..superset/lib/setup/steps.shto write the v2 MCP URL into locally provisioned.mcp.jsonfiles — it was still writing the v1 path while every checked-in agent config (opencode.json,.codex/config.toml,.mastracode/mcp.json) already uses v2.Remaining v1 removal (server package + route) lands separately after the deprecation window + traffic check.
https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
Summary by cubic
Drops Superset MCP tool integration from the v1 chat runtime and updates local setup to use the v2 MCP endpoint, removing the last dependency on the deprecated
/api/agent/mcp. Aligns v1 chat with v2 and starts the v1 MCP sunset.Refactors
getSupersetMcpToolsand its only call site inpackages/chat/src/server/trpc/service.ts.packages/chat/src/server/trpc/utils/runtime/superset-mcp.ts.Bug Fixes
.superset/lib/setup/steps.shto writehttp://localhost:<port>/api/v2/agent/mcpinto local.mcp.json.Written for commit 0f7e61f. Summary will update on new commits.
Summary by CodeRabbit